Empty patch when compare two arrays

[tochti]

Hello,

first thanks for your effort creating this library.

I was wondering if the following behavior is intended?

Actual Behavior

If the following code is executed the result is an empty patch. The reason for that is that the 2nd item in o2 is the "same" item like the item in o1.

import (
	"fmt"

	"github.com/mattbaird/jsonpatch"
)

func main() {

	o1 := []byte(`{"Items":[{"K":1}]}`)
	o2 := []byte(`{"Items":[{"K":1},{"K":1}]}`)

	patch, err := jsonpatch.CreatePatch(o1, o2)
	if err != nil {
		fmt.Println(err)
		return
	}

	fmt.Println("Patch", patch)

}

Expected Behavior

I did expect to get the following patch

[{"op": "add", "path": "/Items/1", "value": {"K":1}}]

Specifications

Version: newest (go get github.com/mattbaird/jsonpatch)

[mengqiy]

@tamalsaha Is this issue fixed in your fork?

[tamalsaha]

I believe so. You can add the test to https://github.com/appscode/jsonpatch/blob/master/jsonpatch_test.go and double check.

[tamalsaha]

@mengqiy , I believe this array test case is covered by https://github.com/appscode/jsonpatch/blob/master/jsonpatch_test.go#L758