gosaml icon indicating copy to clipboard operation
gosaml copied to clipboard

GetUrl - DEFLATE support, embed AuthnRequest in AuthnSignedRequest

Open owen opened this issue 10 years ago • 1 comments

Here's a new round of changes that make this work more nicely with Shibboleth servers. Highlights:

  • All methods now take a binding method that allows the binding type to be changed. I've tested this against HTTP-POST and HTTP-Redirect so far.
  • GetRequestUrl() now deflates the data before base64 & URLEncode. This is needed per the spec.
  • I've embedded an AuthnRequest inside AuthnSignedRequest, which simplified things quite a bit.

You may not want to merge these - I've changed the signatures on some of those functions. I'm not sure if I'm happy with that or not... I might poke at this a bit more to see if I can keep the API from changing.

owen avatar Dec 09 '15 21:12 owen

I'm still thinking about how to keep the existing API as is. if anyone has thoughts, I'd be happy to hack them in.

owen avatar Dec 10 '15 15:12 owen