elastigo icon indicating copy to clipboard operation
elastigo copied to clipboard

Highlighting not handled

Open fvbock opened this issue 10 years ago • 1 comments

Currently elastigo does not use the information from the highlighting functionality es provides. It's basically a one-liner added to the Hit struct. I could make a PR or just post the one-liner here if there is no other reason for not including it.

fvbock avatar Jul 29 '14 09:07 fvbock

sorry. did not see https://github.com/mattbaird/elastigo/pull/111 which includes highlights too. discussion is ongoing there about omitempty and struct types... i took the lazy approach and just made it a *json.RawMessage... (https://github.com/mattbaird/elastigo/pull/117) i will follow the discussion and close these if you guys come to a conclusion there...

fvbock avatar Jul 30 '14 07:07 fvbock