YomiNinja icon indicating copy to clipboard operation
YomiNinja copied to clipboard

JPDBreader support

Open kokoropaint opened this issue 1 year ago • 4 comments

JPDBreader is a browser extension that parses web pages through JPDB and provides furigana+a popup dictionary. The biggest benefit of using it is that you can connect your JPDB account to it and quickly add words to your flashcard deck, plus easily visualize which words you do/don't already know with highlighting. (you can also customize things like not showing furigana for known words, etc.) This extension makes using JPDB as a learning aid very seamless (similar to connecting Yomichan+Anki) so supporting it or something similar in YomiNinja would be great :)

kokoropaint avatar Dec 28 '23 16:12 kokoropaint

I wasn't aware of this extension, but it seems quite useful. Thanks for the suggestion! Accessing the extension settings was a bit tricky, but I managed to do so. I've already made some adjustments to the overlay to handle furigana, and now I need to ensure that the extension settings menu loads correctly.

JPDB Reader

matt-m-o avatar Dec 30 '23 03:12 matt-m-o

Looks great!

madmalkav avatar Jan 05 '24 19:01 madmalkav

Tried testing out 0.5.1's expanded extension support earlier for this, but I'm running into your reported issues with accessing the settings screen. Even if the rest of the page can't render properly yet, is there any way I can import my existing settings from my browser copy using the import/export settings button? There's not a way to use the extension without it having access to your API key.

kokoropaint avatar Feb 15 '24 06:02 kokoropaint

@kokoropaint The v0.5.1 doesn't include support for JPDBReader, so you may encounter many bugs. However, you can attempt to set the API key by right-clicking on the Settings link and selecting Open link in a new window. Although the "window" may appear quite small, you should still be able to set the key from there.

image

matt-m-o avatar Feb 17 '24 00:02 matt-m-o

Should be completely integrated on latest version. Can you please try and, if everything is qorking OK for you, close the ticket?

madmalkav avatar Jun 16 '24 07:06 madmalkav

Did some light testing and everything looks good! :)

kokoropaint avatar Jun 20 '24 01:06 kokoropaint