nanopq icon indicating copy to clipboard operation
nanopq copied to clipboard

Turn print statements into logging

Open stephantul opened this issue 1 year ago • 6 comments

Hi!

Thanks for writing this package, it looks great!

I'd be interested in turning the print statements (with verbose=True) into logging statements. The verbose flag could then be used to control whether this logging is output to stdout (i.e., by setting the log level). Is this something you are interested in? if so, I could submit a PR.

stephantul avatar May 07 '23 11:05 stephantul

Thanks! Just wait a bit, I need to take a look at this PR first #24 (I haven't had time to work on this PR for a long time, though...)

Once that is done, please make a PR! As I'd like to keep this repository as simple as possible, very simple logging is appreciated :)

matsui528 avatar May 22 '23 15:05 matsui528

Thanks for the response, I'll wait! If you want, you can ping me when this can be started.

stephantul avatar May 23 '23 04:05 stephantul

@stephantul Sorry for the super long delay... Now you can start :+1:

matsui528 avatar Sep 07 '23 08:09 matsui528

If this is still open can I work on this?

DivyanshVinayak23 avatar Jun 12 '24 11:06 DivyanshVinayak23

@DivyanshVinayak23 Sure, I totally forgot to pick this up. (@matsui528 my apologies 🙏 )

stephantul avatar Jun 13 '24 18:06 stephantul

@DivyanshVinayak23 @stephantul Thanks! Please go ahead :+1:

matsui528 avatar Jun 16 '24 23:06 matsui528