matsim-libs icon indicating copy to clipboard operation
matsim-libs copied to clipboard

Delete `maxBicycleSpeedForRouting` in `BicycleConfigGroup`

Open paulheinr opened this issue 6 months ago • 0 comments

This parameter is deprecated and should not be used anymore. The velocity of a vehicle should always be used. For access-egress-routing this is the case. But in org.matsim.core.router.NetworkRoutingModule#calcRoute null is passed as vehicle.

Since this class is already deprecated and should be deleted with #3354, I think we should focus on deleting maxBicycleSpeedForRouting in the bicycle contrib. To do this, the bicycle tests must be adapted (and maybe something else). As long as org.matsim.core.router.NetworkRoutingModule is not deleted, a consistency check should be made, if this is used.

paulheinr avatar Aug 09 '24 13:08 paulheinr