matsim-libs icon indicating copy to clipboard operation
matsim-libs copied to clipboard

Issues with SBB skim matrices

Open markusstraub opened this issue 2 years ago • 0 comments

I believe (maybe I understood something wrong, @mrieser ?) I found the following issues with the SBB skim matrices, which, by the way, are a very helpful feature :)

pt access/egress calculation time is not normalized to 1 hour

When calculating access/egress times RooftopUtils.calcConnectionShares does not normalize the given duration. This means the sum of all shares is 1 for a 1 hour time window (as expected), but 2 for a 2 hour time window. This then results in the access/egress times (in the matrices) being too large.

pt travel time

The javadoc explains, that the travel time matrices such as pt_travel_times.csv.gz contain the pure travel time. This does not seem to be the case, it includes access and egress times - as expected when looking at PTSkimMatrices

That's no big deal but the documentation and code are out of sync.

markusstraub avatar Jul 27 '22 13:07 markusstraub