Matthias Riße
Matthias Riße
I am pretty sure that all of those `try: ... except ModuleNotFoundError: ...` blocks will break the test suite in many ways. I'd rather not have those and make it...
> all tests succeeds. In CI yes, because all dependencies are installed. There these try blocks serve no purpose. If I just uninstall keyring and run the test suite I...
I just commented on this because you mentioned me. I see that this is a draft, so as long as those try-blocks are not intended to be in the to-be-merged...
I've found this older discussions related to black, which I think Reimar initially referenced in #2144 regarding black breaking MSS: https://github.com/Open-MSS/MSS/pull/618#discussion_r553611510. > black was rather aggressive and, let's say controversial,...
ruff also has another major advantage over flake8: it respects gitignore, so it automatically skips all files that are also ignored by git.
Even when explicitly linking a PR to an issue the issue is not automatically closed, for some reason. This happened in #2205: I've linked the PR to #2199 manually, then...
> We have for a good reason a stable branch. This is used to destinguish what features and bug fixes are for. I am not suggesting to get rid of...
> The amount of people is much relevant, it is not a one man project for only one user. This means when there is a campaign the only way we...
To collect some practical issues the current workflow caused: - In #2323 at first msidp was missing from the entrypoints. I only caught this because I knew I had to...
Another thing that would not be necessary anymore with the workflow suggested here: manually enabling merges for the merge PRs. With the suggested workflow every PR would always be a...