matrixone icon indicating copy to clipboard operation
matrixone copied to clipboard

[Bug]: Constraint of Composite Primary Key is stored in tae

Open domingozhang opened this issue 2 years ago • 1 comments

Is there an existing issue for the same bug?

  • [X] I have checked the existing issues.

Environment

- Version or commit-id (e.g. v0.1.0 or 8b23a93):
- Hardware parameters:
- OS type:
- Others:

Actual Behavior

Currently, the Composite Primary Key is not stored as a Constraint yet

Expected Behavior

No response

Steps to Reproduce

No response

Additional information

No response

domingozhang avatar Oct 13 '22 07:10 domingozhang

I think now cpkey is implmented in the compute layer, so Xu Peng please talk with Tian Feng, give a conclusion

bbbearxyz avatar Oct 13 '22 08:10 bbbearxyz

I think now cpkey is implmented in the compute layer, so Xu Peng please talk with Tian Feng, give a conclusion

must be stored @bbbearxyz

nnsgmsone avatar Oct 14 '22 09:10 nnsgmsone

in the pr #6221, Primary Key Info is stored in tae by schema.SortKey and schema.Field, return the def by engine.PrimaryIndexDef

bbbearxyz avatar Nov 03 '22 09:11 bbbearxyz

will fix later

bbbearxyz avatar Nov 09 '22 04:11 bbbearxyz

will fix later

bbbearxyz avatar Nov 13 '22 16:11 bbbearxyz

It's a feature issue. And it is in the scope of #5590.

aunjgr avatar Nov 17 '22 16:11 aunjgr

No effort until now.

aunjgr avatar Nov 21 '22 11:11 aunjgr

No progress on this issue yet.

aunjgr avatar Nov 25 '22 13:11 aunjgr

TableDef will be refactored after the design is finalized next week. All types of constraints will be put in a unified frame accordingly.

aunjgr avatar Dec 01 '22 04:12 aunjgr

Working on #6616. TableDef is still in desigining.

aunjgr avatar Dec 05 '22 11:12 aunjgr

track the progress at #5590

aunjgr avatar Dec 08 '22 11:12 aunjgr

Refactor of TableDef has begun.

aunjgr avatar Dec 13 '22 11:12 aunjgr

Primary key constraint will be refactored by @bbbearxyz

aunjgr avatar Dec 27 '22 15:12 aunjgr

Has passed it on to @bbbearxyz

aunjgr avatar Jan 03 '23 10:01 aunjgr

in the next week, after i support secondary key, i will solve this issue.

bbbearxyz avatar Jan 06 '23 11:01 bbbearxyz

I will fix when i support all the secondary key feature.

bbbearxyz avatar Jan 09 '23 11:01 bbbearxyz

I will fix when i support all the secondary key feature.

bbbearxyz avatar Jan 12 '23 10:01 bbbearxyz

I will fix when i support all the secondary key feature.

bbbearxyz avatar Jan 16 '23 11:01 bbbearxyz

I will fix after the new year rest day

bbbearxyz avatar Jan 19 '23 09:01 bbbearxyz

i will fix it in the later

bbbearxyz avatar Jan 28 '23 13:01 bbbearxyz

i will fix it in the later

bbbearxyz avatar Jan 31 '23 09:01 bbbearxyz

It is being processed

qingxinhome avatar Feb 01 '23 11:02 qingxinhome

This function has been completed and pr has been submitted. Please accept and test. @nnsgmsone @domingozhang @daviszhen @aunjgr @bbbearxyz

qingxinhome avatar Feb 05 '23 03:02 qingxinhome

composite primary key bvt case merged ,this issue closed image

heni02 avatar Feb 07 '23 07:02 heni02