matrixone icon indicating copy to clipboard operation
matrixone copied to clipboard

Published 20 hours ago • verified publisher icon matrixorigin

Add timezone support

Open aunjgr opened this issue 2 years ago • 1 comments

What type of PR is this?

  • [ ] API-change
  • [x] BUG
  • [ ] Improvement
  • [ ] Documentation
  • [x] Feature
  • [x] Test and CI
  • [ ] Code Refactoring

Which issue(s) this PR fixes:

issue #3703 #3655

What this PR does / why we need it:

It's an incomplete effort of timezone support. However, it reaches a status that all bvt and ut can pass. More timezone related updates will be in following PRs.

aunjgr avatar Aug 13 '22 16:08 aunjgr

Hi, can you please write a good commit message? What did you do, what has changed, where is timezone stored, or session timezone works, etc.. Or link to a doc.

Thank you.

fengttt avatar Aug 15 '22 01:08 fengttt

I am very concerned about the performance of this change.

Can you please add a golang benchmark test, do datetime_add and compare that of using old code without timezone, and new code with timezone. Let me know how big is the difference.

{data,datetime}_{add,sub} has been rewritten. It doesn't involve timezone now.

aunjgr avatar Aug 15 '22 10:08 aunjgr