matrixone icon indicating copy to clipboard operation
matrixone copied to clipboard

[Discussion]: Should we support float(m, n) and double(m, n)?

Open m-schen opened this issue 2 years ago • 2 comments

Is there an existing issue for the same bug?

  • [X] I have checked the existing issues.

Environment

- Version or commit-id (e.g. v0.1.0 or 8b23a93):
- Hardware parameters:
- OS type:
- Others:

Actual Behavior

mysql supported that, and we didn't. And we can accept the sql like create table t1 (a float(6, 2)); create table t2 (b double(20, 4));

we should just reject it at parser or support it really.

Expected Behavior

No response

Steps to Reproduce

No response

Additional information

No response

m-schen avatar Jul 03 '22 09:07 m-schen

Has a conclusion that 0.5 doesn't support float/double with param of precision.

iamlinjunhong avatar Jul 04 '22 06:07 iamlinjunhong

Discuss with @aressu1985, Cases will not modify and plan will not reject form of float/double with param. This issue can move into 0.6.

iamlinjunhong avatar Jul 04 '22 06:07 iamlinjunhong

Hello @m-schen. The bug issue in the BVT test code has not been removed,issues automatically open.

matrix-meow avatar Sep 21 '22 12:09 matrix-meow

it's just a discussion that time. I found that someone try to close it 16 hours age. can I think that we won't support this form of float / double ?

so I closed this issue.

m-schen avatar Sep 22 '22 03:09 m-schen

Hello @m-schen. The bug issue in the BVT test code has not been removed,issues automatically open.

matrix-meow avatar Sep 22 '22 03:09 matrix-meow

link: this Discussion does not work temporarily @m-schen @aressu1985 @fengttt

qingxinhome avatar Nov 07 '22 06:11 qingxinhome