Dobrosław Żybort

Results 39 comments of Dobrosław Żybort

Thank you for this report and sorry it took so long, burnout is not nice... So first: https://github.com/rainycape/unidecode that `slug` package is using underneath have test showing that it is...

Not sure if I want to add this functionality. I saw some forks that have basically only one additional commit with changing separator. Pros: - well, ability to set custom...

Will leave it open for now, maybe someone have some feedback.

Shit, one more bug now with `defaultSub`s initialized with `init`...

Hi, thank you for this PR. I'm sick now and don't have much strength for review so just some short comments. Could you add tests to this new functionality? I...

Also did you looked at benchmarks how much speed degrade with your change? You could add info about it to doc.go and readme or I will do it after merging.

Hello and thank for this changes. I moved removing of Go 1.13 requirement to another PR and merged with master #42 because I always squash pull requests and wanted it...

Travis run tests by default with `-race` https://github.com/gosimple/slug/blob/master/.travis.yml#L18 So if you add test it should find if anything bad happen to the code at future.

I'm on short vacations now, will check it on Wednesday.