matrixprofile icon indicating copy to clipboard operation
matrixprofile copied to clipboard

pip install matrixprofile forces protobuf==3.11.2

Open carlydf opened this issue 3 years ago • 18 comments

Describe the bug We need protobuf > 3.11.2 for other dependencies.

To Reproduce Steps to reproduce the behavior:

  1. pip install matrixprofile
  2. pip install --upgrade protobuf Should install protobuf v3.17.3 which it does. It also errors saying matrixprofile 1.1.10 requires protobuf==3.11.2, but you have protobuf 3.17.3 which is incompatible. despite the fact that matrixprofile/requirements.txt in v1.1.10 says protobuf>=3.11.2,<4.0.0
  3. pip install matrixprofile This uninstalls protobuf and installs protobuf==3.11.2, which is the wrong behavior

Expected behavior I expect protobuf to be left alone, since the stated requirements for matrixprofile is just protobuf>=3.11.2,<4.0.0

Additional context I believe the problem is that matrixprofile/setup.py required protobuf==3.11.2 until March 8, 2021, and the latest release was released on January 16, 2021. I think the bug would be fixed by creating another release.

pip installing matrixprofile from the commit where setup.py relaxed the protobuf version requirement resolves the issue

carlydf avatar Jul 26 '21 16:07 carlydf

Hi @carlydf, thanks for letting me know! I'll look into it shortly.

vanbenschoten avatar Aug 02 '21 20:08 vanbenschoten

Hello there,

I'm currently with the same problem. Despite the requirements.txt shows a clear protobuf>=3.11.2,<4.0.0 the pip install print out this error: protobuf==3.11.2 (from matrixprofile==1.1.10 . . .

This happens because I have another dependency that needs protobuf>=3.12.0

How to replicate:

  • $ python3 -m venv .venv
  • $ source .venv/bin/activate
  • $ pip3 install matrixprofile protobuf>=3.12.0
  • Error is: matrixprofile 1.1.10 requires protobuf==3.11.2

pedro-ricardo avatar Aug 13 '21 23:08 pedro-ricardo

@vanbenschoten do you have an estimate to have this looked into?

pedro-ricardo avatar Aug 13 '21 23:08 pedro-ricardo

@pedro-ricardo not at the moment, though hopefully soon.

vanbenschoten avatar Aug 15 '21 22:08 vanbenschoten

Thank you for the feedback. We'll find a workaround. :+1:

pedro-ricardo avatar Aug 16 '21 11:08 pedro-ricardo

I think the bug would be fixed by creating another release.

in the original issue, @carlydf pointed out the fix is already implemented, but no release has been published

for now pip install git+ssh://[email protected]:matrix-profile-foundation/matrixprofile.git will get you the github version with the correct requirements.txt

peterdhansen avatar Aug 16 '21 21:08 peterdhansen

Installing through pip does solve the install issue.

But some dependency resolver, like the ones from Kedro, start to have bugs with this .. like:

ERROR: Cannot install matrixprofile 1.1.10 (from git+git://github.com/matrix-profile-foundation/matrixprofile@6bea7d4445) because these package versions have conflicting dependencies
The conflict is caused by:
    The user requested matrixprofile 1.1.10 (from git+git://github.com/matrix-profile-foundation/matrixprofile@6bea7d4445)
    my-package 1.1.0 depends on matrixprofile 1.1.10 (from git+https://github.com/matrix-profile-foundation/matrixprofile.git@6bea7d4445)

This does not make sense at all .. and it is not your problem ...

But how far are we from releasing the master branch as 1.1.11 ?

pedro-ricardo avatar Sep 06 '21 22:09 pedro-ricardo

@vanbenschoten A release would really be great 🙏🏼

aberres avatar Oct 22 '21 11:10 aberres

Got same issue on install v1.1.10. It would be really helpful if release a patch. 🙏

theoohoho avatar Nov 17 '21 09:11 theoohoho

Got same issue on install v1.1.10. It would be really helpful if release a patch. 🙏

I would second this. A release would be great.

uabbas avatar Nov 25 '21 13:11 uabbas

I would also be happy about a release!

RouvenG avatar Dec 17 '21 11:12 RouvenG

Still a problem

eliorc avatar Jan 24 '22 11:01 eliorc

Would also be happy for a release please.

I am not trying to pip install matrixprofile, but rather I am using a package which has a dependency on matrixprofile. Either way the same problem occurs.

I have been able to resolve the protobuf==3.11.2 conflict by including the below in my personal projects setup.py file.

install_requires=["matrixprofile @ git+https://[email protected]/matrix-profile-foundation/matrixprofile.git"]

Hopefully this can help anyone with the same issue.

rose-harry avatar Jan 26 '22 09:01 rose-harry

Would also be happy for a patch release please.

gchlebus avatar Mar 04 '22 09:03 gchlebus

A patch release would be amazing! A few downstream libraries depend on you guys and protobuf seem to be used quite a bit so conflicts arise often. Furthermore, a release should be straight forward as you already have the fix in master at commit: cf342ba6adf29cf7efc28a12ccb978a9a1b8f3eb

tim-x-y-z avatar May 11 '22 09:05 tim-x-y-z

Hey everyone! Any roadmap on this one? I just hit it myself. Thanks! Let me know if I could help somehow in testing!

ekamperi avatar Jun 02 '22 20:06 ekamperi

Also an issue for us. Has anyone found a workaround?

jackalack avatar Aug 05 '22 01:08 jackalack

Can confirm, the issue still exists. Is this software even being actively managed anymore?

jcoffi avatar Sep 26 '22 22:09 jcoffi

This library is no longer actively maintained. We recommend using the STUMPY library moving forward: https://github.com/TDAmeritrade/stumpy

vanbenschoten avatar Nov 25 '22 13:11 vanbenschoten