synapse
                                
                                 synapse copied to clipboard
                                
                                    synapse copied to clipboard
                            
                            
                            
                        Document Google OpenID Connect email attribute
In the example config
Pull Request Checklist
- [x] Pull request is based on the develop branch
- [ ] Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStoretoEventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
 
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from 
- [ ] Pull request includes a sign off
- [ ] Code style is correct (run the linters)
This is a very short documentation change that I made using the GitHub web editor. Please let me know if all the boxes still need to be ticked
* add a changelog entry * a comment with your sign-off
How do you perform these steps using the GitHub web interface?
There's no need to run the linters for a documentation-only change like this.
Thanks, that's what I thought.
How do you perform these steps using the GitHub web interface?
For adding a changelog entry, I think you want to go to the fork and branch that github has created for you and follow the instructions here.
For adding a sign-off, writing a comment on this PR with Signed-off-by: as per the notes here is all that's needed.
* add a changelog entry * a comment with your sign-offHow do you perform these steps using the GitHub web interface?
You can go to https://github.com/ptman/synapse/tree/patch-1/changelog.d and click the + in the top right and choose "Create new file".
For sign-off you can just add it manually via a comment on the PR.
Signed-off-by: Paul Tötterman [email protected]