synapse Mark /relations endpoint as usable on workers.

This has always been safe to my knowledge, but now there are complement tests (matrix-org/complement#467).

Fixes #12290

Oct 03 '22 16:10 clokep

For what it's worth, I get an error on isolated client_reader tests. My test repo

Oct 03 '22 19:10 realtyem

Hmmm, maybe we're not mounting that properly, but why isn't it failing in this repo?! 😢

Oct 03 '22 20:10 clokep

The Complement testing machinery on the synapse side defines what workers are being used, which is not a full set. Only known good workers are utilized. I believe it's declared in start_for_complement.sh or such? On Mon, Oct 3, 2022, 3:13 PM Patrick Cloke @.***> wrote:

Hmmm, maybe we're not mounting that properly, but why isn't it failing in this repo?! 😢

— Reply to this email directly, view it on GitHub https://github.com/matrix-org/synapse/pull/14028#issuecomment-1265976131, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMCKHN7EOKBO4DP7VALGVLWBM455ANCNFSM6AAAAAAQ3XUQG4 . You are receiving this because you commented.Message ID: @.***>

Oct 03 '22 20:10 realtyem

Ah ok, so this goes to my comment above saying that I don't. Now if adding the config is all that's needed. Thanks for answering!

Oct 03 '22 20:10 clokep

That looks good for testing with the docker image. Outside of that is out of my scope of expertise. For example: I don't know enough about the internals of how generic_workers become actual workers to say that defining an endpoint and giving it an arbitrary name is sufficient. Documentation is...misleading, in this aspect.

Oct 04 '22 00:10 realtyem

Can you update the docs/workers.md documentation please?

This PR already updates that w/ the new endpoint. Is there an additional change you'd like to see?

Oct 12 '22 10:10 clokep

Can you update the docs/workers.md documentation please?

This PR already updates that w/ the new endpoint. Is there an additional change you'd like to see?

I swear that wasn't there before!!!!

Oct 12 '22 10:10 erikjohnston