synapse icon indicating copy to clipboard operation
synapse copied to clipboard

retention comes with insufficient warnings

Open richvdh opened this issue 3 years ago • 5 comments

it is well-known to corrupt the database via insufficient cache invalidation, yet the config documentation almost recommends it. It needs a big health warning

richvdh avatar Aug 08 '22 11:08 richvdh

cf https://github.com/matrix-org/synapse/issues/13476

richvdh avatar Aug 08 '22 12:08 richvdh

What happens if I decide (because of mentioned risk) to remove retention: enabled: true from configuration and many rooms in my HS have retention configured? Is it safe? Please add that to docs also.

4nd3r avatar Aug 08 '22 12:08 4nd3r

And are there different risks if I delete history e.g. from yesterday or 3 years ago?

dklimpel avatar Aug 08 '22 12:08 dklimpel

What happens if I decide (because of mentioned risk) to remove retention: enabled: true from configuration and many rooms in my HS have retention configured? Is it safe?

I believe that's fine, yes.

Please add that to docs also.

Pull requests to improve the documentation are always welcome :innocent:

richvdh avatar Aug 08 '22 18:08 richvdh

And are there different risks if I delete history e.g. from yesterday or 3 years ago?

Yes, there are different risks in the sense that you're less likely to hit one of the problematic races by deleting history from 3 years ago than by deleting history from yesterday.

richvdh avatar Aug 08 '22 18:08 richvdh