synapse
synapse copied to clipboard
add Module API callback for user directory search
Signed-off-by: Krisztian Szegi [email protected]
Pull Request Checklist
- [x] Pull request is based on the develop branch
- [ ] Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from
EventStore
toEventWorkerStore
.". - Use markdown where necessary, mostly for
code blocks
. - End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from
- [x] Pull request includes a sign off
- [x] Code style is correct (run the linters)
I'd like this to be merged, so #12247 could be closed. I could then add the callback to matrix-synapse-ldap3 auth backend, making the latter a 100% replacement for the dead ma1sd, at least in a LDAP based setup.
Is there no docs needed for synapse/docs/modules/
?
Fair enough - I'll add the docs, and remove the commented out loop!
Cool, thank you for the PR 🥳
We also need this feature, thus your PR looks very promising. Keep up your good work! Looking forward to get it into Synapse 😃
@Samonitari or @janpawellek -- do you wish to continue this PR? It looks like it needs some updates and the feedback addressed.
Yes, but to be a bit more direct - and to not make any bloody estimation lies - sometime this year I'll do this. I'll keep you updated, but the next two weeks I am consolidating two hosting servers into one - I am halfway there!