synapse
synapse copied to clipboard
PreviewUrlResource: set `od:iframe` in json (#2752)
Set `od:iframe` in json when oembed returns `<iframe/>`
Signed-off-by: Srdjan <[email protected]>
Pull Request Checklist
- [X] Pull request is based on the develop branch
- [X] Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from
EventStoretoEventWorkerStore.". - Use markdown where necessary, mostly for
code blocks. - End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from
- [X] Pull request includes a sign off
- [X] Code style is correct (run the linters)
@srdjan-catalyst Can you expand upon why this is necessary / what this does?
Currently, when oembed api returns html, it is parsed and as far as content is concerned, only images are being looked for. We have a case when an iframe is sent back to display content. That is because of the content being available to authenticated users only so it has to be dealt with on the client side.
This appears blocked on https://github.com/matrix-org/matrix-doc/pull/3338 now?