sygnal Sygnal assumes that the sender field of a notification is non-null

Sygnal assumes that the sender field of a notification is non-null

Open anoadragon453 opened this issue 3 years ago • 1 comments

https://github.com/matrix-org/sygnal/blob/ab6285760d76d345edb78673106d5913cfe69259/sygnal/apnspushkin.py#L343-L346

According to the spec the sender field of a notification can be null, yet Sygnal looks to assume it's a str.

While not common, if sent by a homeserver this would cause Sygnal to return a 500.

Mar 05 '21 13:03 anoadragon453

@anoadragon453 I am starting to work on it. please let me know from where to start. Thanks

Mar 10 '21 20:03 arya2331