mjolnir icon indicating copy to clipboard operation
mjolnir copied to clipboard

Remaining issues after #280

Open ShadowJonathan opened this issue 3 years ago • 0 comments

https://github.com/matrix-org/mjolnir/pull/280 was merged for time pressure, but afaik there's two more things to be looked at;

  • The PR introduced requiredStatePermissions, these announce the permissions a protection would likely need. Currently these only work on a manual !verify command after startup, as protections are only added enabled the startup verify. (And it will only consider enabled protections for the permissions they need)
  • The PR currently uses an hourly bucket, but it was suggested to use a sliding token bucket. This has to be added.

ShadowJonathan avatar May 06 '22 09:05 ShadowJonathan