matrix-spec-proposals icon indicating copy to clipboard operation
matrix-spec-proposals copied to clipboard

MSC4174: Web push

Open p1gp1g opened this issue 1 year ago • 10 comments

rendered

Client implementation: synapse impl: https://github.com/element-hq/synapse/pull/17987 updated hydrogen impl: https://github.com/element-hq/hydrogen-web/pull/1201

Note: in addition to this MSC, it would be very useful to have MSC4173, if someone is interested in implementing this MSC as well

p1gp1g avatar Aug 01 '24 15:08 p1gp1g

Thank you for your feedback @clokep, I'm updated the proposal soon

p1gp1g avatar Aug 07 '24 10:08 p1gp1g

Client implementation: https://github.com/p1gp1g/hydrogen-web/commit/e7cc4880b0d294a989b757aee0c17abee5601aa7

p1gp1g avatar Nov 21 '24 08:11 p1gp1g

synapse impl: https://github.com/element-hq/synapse/pull/17987 updated hydrogen impl: https://github.com/element-hq/hydrogen-web/pull/1201

MatMaul avatar Dec 02 '24 22:12 MatMaul

Implementations seem to implement what's described in the MSC, so removing the needs-checking label

tulir avatar Jan 21 '25 16:01 tulir

We have introduced a handshake to validate a push subscription on the WEBPUSH IMAP extension. Validating the subscription is easy to implement and reduces a lot the risk of a bad actor registering a lot of non-webpush endpoint in order to use it as a DDOS amplification. I think we should introduce it here as well

p1gp1g avatar Mar 24 '25 15:03 p1gp1g

I've added the validation token to the MSC

p1gp1g avatar May 26 '25 12:05 p1gp1g

Upvoting this

warioishere avatar May 30 '25 15:05 warioishere

Last but not least, the title "webpush push kind" sounded a bit like a typo and one has to read it twice to make sense of it. Perhaps rather "Extend Notification pusher to an optional "webpush"" or something similar. "push kind" is kind of very insidery if you already know the spec.

spaetz avatar Jun 01 '25 10:06 spaetz

Thanks @spaetz for your suggestions and review, I've somehow forgotten to get back to them.

I've updated the title to something more simple: web push, and I think I've responded to all your comments

p1gp1g avatar Nov 15 '25 20:11 p1gp1g

@p1gp1g think you have more typos xd

Fuseteam avatar Nov 17 '25 11:11 Fuseteam