matrix-spec-proposals icon indicating copy to clipboard operation
matrix-spec-proposals copied to clipboard
verified publisher icon matrix-org

MSC4027: Propose method of specifying custom images in reactions

Open sumnerevans opened this issue 2 years ago • 9 comments

A proposal to render MXC URIs in reaction keys as images.

Rendered

Implementations

Clients

  • Schildichat
    • Android: https://github.com/SchildiChat/SchildiChat-android/commit/85a26ae8bea7d1425019df31b05ff72541ad61dd
    • Desktop implementation (hasn't landed in a release yet): https://github.com/SchildiChat/matrix-react-sdk/commit/4d104fc87f8d32da679476967850c5f7a9c20c8a
  • Beeper (all platforms)
  • Element Web: https://github.com/matrix-org/matrix-react-sdk/pull/11087
  • Element X Android: https://github.com/element-hq/element-x-android/pull/2160
  • Cinny: https://github.com/cinnyapp/cinny/pull/686/commits/519f620cb7660b665602e3799bd63dff7e4382a6

Bridges

  • mautrix-discord: https://github.com/mautrix/discord/blob/00465bb71509b984614ed41fa4f147a9d6bd4b3a/example-config.yaml#L145-L147

Supercedes #3746

FCP tickyboxes

sumnerevans avatar Jun 10 '23 00:06 sumnerevans

I don't think this deserves the needs-implementation label as it is already implemented across multiple clients and at least one bridge.

sumnerevans avatar Jun 12 '23 15:06 sumnerevans

Some extra details concerning SchildiChat:

  • Android implementation: https://github.com/SchildiChat/SchildiChat-android/commit/85a26ae8bea7d1425019df31b05ff72541ad61dd
  • Desktop implementation (hasn't landed in a release yet): https://github.com/SchildiChat/matrix-react-sdk/commits/4d104fc87f8d32da679476967850c5f7a9c20c8a
  • We don't do anything with shortcode yet :upside_down_face:

SpiritCroc avatar Jun 12 '23 20:06 SpiritCroc

I played around with https://github.com/matrix-org/matrix-react-sdk/pull/11087 and it looks good! Removing the needs-implementation label.

anoadragon453 avatar Jun 16 '23 20:06 anoadragon453

This proposal is implemented in Out Of Your Element: https://gitdab.com/cadence/out-of-your-element/compare/c7ddf638dbd658057ec6a7a018a23b0693a97890~..044ccc08e06f11b48e16c7f7637d3c088008119a#diff-0f01ec9090ff5700793cc2f6399fb95cf3a7115f

It follows the spec and it works with Schildi and Cinny.

cloudrac3r avatar Sep 22 '23 01:09 cloudrac3r

It seems like Element now has this setting in Labs, and it works very well. image

Cyrus-Harding avatar Sep 25 '23 10:09 Cyrus-Harding

Unable to add concern. Is this msc in FCP-proposed state?

mscbot avatar Sep 25 '23 17:09 mscbot

Unable to add concern. Is this msc in FCP-proposed state?

mscbot avatar Sep 25 '23 17:09 mscbot

This FCP proposal has been cancelled by https://github.com/matrix-org/matrix-spec-proposals/pull/4027#issuecomment-2030612259.

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

  • [ ] @clokep
  • [ ] @dbkr
  • [ ] @uhoreg
  • [ ] @turt2live
  • [ ] @ara4n
  • [ ] @anoadragon453
  • [ ] @richvdh
  • [ ] @tulir
  • [ ] @erikjohnston
  • [ ] @KitsuneRal

Concerns:

  • Requiring two : characters in every shortcode string.
  • Needs to be reviewed against other custom emoji/sticker MSCs

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

mscbot avatar Sep 25 '23 17:09 mscbot

As this is tied to the media linking series and unable to progress otherwise, I'm cancelling FCP for the time being.

This does not mean the MSC is unimportant, but rather the focus is elsewhere at the moment.

@mscbot fcp cancel

turt2live avatar Apr 01 '24 21:04 turt2live