matrix-spec-proposals
matrix-spec-proposals copied to clipboard
MSC3030: Jump to date API endpoint
MSC3030: Jump to date API endpoint
Homeserver implementations:
- Synapse: https://github.com/matrix-org/synapse/pull/9445
Client implementations:
-
/jumptodate
slash command, https://github.com/matrix-org/matrix-react-sdk/pull/7372 - Jump to date headers (with date picker) in timeline: https://github.com/matrix-org/matrix-react-sdk/pull/7339
Related issues:
- https://github.com/vector-im/element-web/issues/7677
- https://github.com/matrix-org/synapse/issues/7164
Removing the needs-implementation
label as this MSC has both an accepted client and server implementation.
no, really:
@mscbot fcp merge
Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:
- [x] @dbkr
- [x] @uhoreg
- [x] @turt2live
- [x] @ara4n
- [x] @anoadragon453
- [x] @richvdh
- [ ] @erikjohnston
- [ ] @KitsuneRal
Concerns:
- ~~Implementation cannot be tested~~
- ~~Authentication / rate limiting~~
- ~~Document why alternatives were rejected~~
- ~~The dir parameter is unclear/questionable~~
- ~~Context API doesn't appear to work with backfilling (likely spec bug)~~
- ~~Server doesn't appear to be able to forwards-fill over federation~~
Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for information about what commands tagged team members can give me.
Reported OOB:
@mscbot concern Implementation cannot be tested
@mscbot concern Authentication / rate limiting @mscbot concern Document why alternatives were rejected @mscbot concern Context API doesn't appear to work with backfilling (likely spec bug) @mscbot concern The dir parameter is unclear/questionable
@mscbot resolve Implementation cannot be tested
Thanks :)
@mscbot resolve Authentication / rate limiting
@mscbot resolve Document why alternatives were rejected @mscbot resolve The dir parameter is unclear/questionable
I believe this is currently waiting for @turt2live to take a look.
I don't think this concern is adding any value at the moment:
@mscbot resolve Context API doesn't appear to work with backfilling (likely spec bug)
... however there is still a problem with context and backfilling:
@mscbot concern Server doesn't appear to be able to forwards-fill over federation
(ref https://github.com/matrix-org/matrix-spec-proposals/pull/3030#discussion_r992858817 )
I think generally this is back to being ready for review from the wider team, barring any edits which need to be made to the MSC itself.
I appear to be the only one with the concern, so in the interest of not blocking this needlessly:
@mscbot resolve Server doesn't appear to be able to forwards-fill over federation
we should, however, figure out how to fix this at some point.
:bell: This is now entering its final comment period, as per the review above. :bell:
The final comment period, with a disposition to merge, as per the review above, is now complete.
![image](https://user-images.githubusercontent.com/720821/200263560-9415b6bd-a957-4374-978e-468f3222e45e.png)
@turt2live shouldn't this go into main
?
Older MSCs go to old_master due to branch conflicts, and will be brought over to main over time (usually when I'm at a terminal that can cherry pick)
Thanks all for the review! 😇
Next up is stabilizing the implementations in Synapse and Element where I made the experimental implementations.
Spec PR (WIP as of writing): https://github.com/matrix-org/matrix-spec/pull/1366
Merged! :tada: