matrix-rust-sdk icon indicating copy to clipboard operation
matrix-rust-sdk copied to clipboard

feat(wasm): Upgrade to uniffi 0.29.3 to support wasm targets

Open zzorba opened this issue 6 months ago • 3 comments

Upgrade to what will soon be uniffi 0.29.3 (release is planned for next week). This mostly concerns an upgrade of the xtask orchestration system, but there were some small changes to the .udl spec that were needed as well.

This will likely produce issues with the complement-crypto package, which seems to still be using uniffi 0.25 to build.

  • [ ] Public API changes documented in changelogs (optional)

Signed-off-by: Daniel Salinas

zzorba avatar Jun 06 '25 13:06 zzorba

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 85.09%. Comparing base (47e8181) to head (bc1129a). :warning: Report is 1414 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5189   +/-   ##
=======================================
  Coverage   85.08%   85.09%           
=======================================
  Files         328      328           
  Lines       36877    36877           
=======================================
+ Hits        31376    31379    +3     
+ Misses       5501     5498    -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 06 '25 14:06 codecov[bot]

What's the status of this PR?

Hywan avatar Jun 16 '25 08:06 Hywan

@Hywan this PR is still necessary, it upgrades us to the most recent uniffi (0.29.3) which contains support for Wasm targets. Without it the matrix-sdk-ffi crate will not compile.

It is unfortunately blocked on the complement-crypto library, which I believe is blocked on NordSecurity considering an upgrade I submitted https://github.com/NordSecurity/uniffi-bindgen-go/pull/77.

I believe Matthew has asked someone to look into the complement-crypto issue, which I believe is currently monkey-patching to work with a very old version of uniffi.

zzorba avatar Jun 17 '25 15:06 zzorba

Superseded by https://github.com/matrix-org/matrix-rust-sdk/pull/5808.

I'm not particularly sure why this PR is so much more complex compared to #5808, so if some of this complexity is needed please open a new PR on top of #5808.

poljar avatar Oct 29 '25 08:10 poljar