matrix-rust-sdk icon indicating copy to clipboard operation
matrix-rust-sdk copied to clipboard

Move to Uniffi 0.29, adjust async callback macros

Open zzorba opened this issue 7 months ago • 4 comments

  • Moves to a commit just past uniffi 29.2, which includes changes needed to target wasm32-unknown-unknown targets for web-browsers.
  • Adjust imports in toml files to import the proper parts of tokio, and avoid those that are incompatible on wasm32 platforms.
  • matrix-sdk-ffi will not compile on wasm32 yet, but this is a step towards that goal.

Also contains matrix-sdk-common changes from https://github.com/matrix-org/matrix-rust-sdk/pull/5079

  • [ ] Public API changes documented in changelogs (optional)

Signed-off-by: Daniel Salinas

zzorba avatar May 23 '25 00:05 zzorba

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 85.83%. Comparing base (f108840) to head (76aecab). :warning: Report is 1584 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5080   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files         333      333           
  Lines       36158    36158           
=======================================
+ Hits        31035    31037    +2     
+ Misses       5123     5121    -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 23 '25 17:05 codecov[bot]

Looks like the uniffi-go tool that is being used has been semi-abandoned by the maintainers. Curious what you recommend doing in this situation.

zzorba avatar May 23 '25 20:05 zzorba

Looks like the uniffi-go tool that is being used has been semi-abandoned by the maintainers. Curious what you recommend doing in this situation.

Huh? Are we talking about the same thing? We're using uniffi-bindgen-go for our integration tests, which has been updated to 0.28.3 recently: https://github.com/NordSecurity/uniffi-bindgen-go/pull/75.

poljar avatar May 24 '25 18:05 poljar

Yes that repo -- I was reading an issue talking about a past uniffi upgrade, and the maintainers said "PRs welcome but we have no planned updates"

I had claude code take a crack at the upgrade to 0.29.2 here https://github.com/NordSecurity/uniffi-bindgen-go/pull/77, we will see what they think.

zzorba avatar May 27 '25 15:05 zzorba

What's the relationship between this and #5189? Do they stack on top of each other or are they duplicates?

Can this one be closed if #5189 is the one true uniffi bump PR?

poljar avatar Jul 28 '25 11:07 poljar

Superseded by #5808.

poljar avatar Oct 29 '25 08:10 poljar