matrix-rust-sdk icon indicating copy to clipboard operation
matrix-rust-sdk copied to clipboard

crypto: Fetch immediately-available sender data when we receive a room key

Open andybalaam opened this issue 1 year ago • 3 comments

Part of https://github.com/matrix-org/matrix-rust-sdk/issues/3543. Builds on top of https://github.com/matrix-org/matrix-rust-sdk/pull/3556

Implements the "fast lane" as described in https://github.com/matrix-org/matrix-rust-sdk/issues/3544

This will begin to populate InboundGroupSessions with the new SenderData struct introduced in https://github.com/matrix-org/matrix-rust-sdk/pull/3556 but it will only do it when the information is already available in the store. Future PRs for this issue will query Matrix APIs using spawned async tasks.

Future issues will do retries and migration of old sessions.

andybalaam avatar Jun 20 '24 16:06 andybalaam

Rebasing because this is a mess after the merge of https://github.com/matrix-org/matrix-rust-sdk/pull/3556

andybalaam avatar Jul 01 '24 14:07 andybalaam

Rebased on top of https://github.com/matrix-org/matrix-rust-sdk/pull/3633

andybalaam avatar Jul 01 '24 15:07 andybalaam

Codecov Report

Attention: Patch coverage is 86.58537% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.37%. Comparing base (a5dbfa6) to head (d496196). Report is 18 commits behind head on main.

Files Patch % Lines
...rypto/src/olm/group_sessions/sender_data_finder.rs 80.48% 8 Missing :warning:
...k-crypto/src/session_manager/group_sessions/mod.rs 87.50% 3 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3590   +/-   ##
=======================================
  Coverage   84.37%   84.37%           
=======================================
  Files         258      259    +1     
  Lines       26656    26722   +66     
=======================================
+ Hits        22491    22547   +56     
- Misses       4165     4175   +10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 01 '24 15:07 codecov[bot]

@poljar this is now rebased and ready to review.

andybalaam avatar Jul 04 '24 10:07 andybalaam

I wonder why our CI check for fixup commits didn't kick in

Or maybe because I just manually named the commits with fixup: rather than using --fixup because that doesn't allow me to describe the commit (unless I missed a flag)

andybalaam avatar Jul 16 '24 12:07 andybalaam