matrix-rust-sdk icon indicating copy to clipboard operation
matrix-rust-sdk copied to clipboard

Add send-call-notify to FFI

Open toger5 opened this issue 1 year ago • 2 comments

Depends on: https://github.com/ruma/ruma/pull/1704

This only adds helper functions to the FFI to send call notify events. Signed-off-by: Timo K [email protected]

  • [x] Public API changes documented in changelogs (optional)

Signed-off-by:

toger5 avatar Nov 22 '23 21:11 toger5

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (19526ce) 83.50% compared to head (b002c18) 83.51%.

Files Patch % Lines
crates/matrix-sdk/src/room/mod.rs 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2874      +/-   ##
==========================================
+ Coverage   83.50%   83.51%   +0.01%     
==========================================
  Files         221      221              
  Lines       23007    23009       +2     
==========================================
+ Hits        19212    19217       +5     
+ Misses       3795     3792       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 27 '23 16:11 codecov[bot]

Could indeed be moved to matrix-sdk. Its very call specific so I was hesitent. But I would really like to make it part of the actual sdk.

toger5 avatar Dec 04 '23 14:12 toger5

Closing inactive Element Call PRs, anyone feel free to open a new one based on this if you're interested to work on this feature.

bnjbvr avatar May 02 '24 08:05 bnjbvr