matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard
verified publisher icon matrix-org

Set relations helper when creating event tile context menu

Open Johennes opened this issue 3 years ago • 2 comments

Fixes https://github.com/vector-im/element-web/issues/22018

Checklist

  • [x] Tests written for new code (and old code if feasible)
  • [x] Linter and other CI checks pass
  • [x] Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Set relations helper when creating event tile context menu (#9253). Fixes vector-im/element-web#22018.

Johennes avatar Sep 06 '22 18:09 Johennes

this seems fine code-wise, but a regression test at a minimum would be appreciated.

I couldn't find a better way of doing this other than hooking into the existing e2e test. Let me know if that is ok.

Johennes avatar Sep 07 '22 19:09 Johennes

@turt2live I think this is good to merge now.

Johennes avatar Sep 15 '22 10:09 Johennes

@turt2live could you merge this one for me please?

Johennes avatar Oct 18 '22 18:10 Johennes

Sure, also I'm going to add you to a useful team for this.

turt2live avatar Oct 18 '22 19:10 turt2live