matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Fix playback queue (autoplay paused message and own vm)

Open grimhilt opened this issue 3 years ago • 2 comments

Fixes https://github.com/vector-im/element-web/issues/20817 Fixes https://github.com/vector-im/element-web/issues/22713 Improves https://github.com/vector-im/element-web/issues/20189 Related to https://github.com/vector-im/element-web/issues/22680

  1. Paused message are no more included in the playback system
  2. Voice message will continue until a something different than a voice message (as previously) or a voice message that we send.
  3. I wasn't able to reproduce but I suspect it has something to do with the previous behavior of paused message.

Signed-off-by: [email protected]

Here's what your changelog entry will look like:

✨ Features

Playback queue is stopped by own voice message. (https://github.com/matrix-org/matrix-react-sdk/pull/9140). Contributed by @grimhilt.

🐛 Bug Fixes

Remove autoplay of paused message. (https://github.com/matrix-org/matrix-react-sdk/pull/9140). Contributed by @grimhilt.

type: T-Enhancement, T-Defect


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Fix playback queue (autoplay paused message and own vm) (#9140). Fixes vector-im/element-web#20817 and vector-im/element-web#22713. Contributed by @grimhilt.

grimhilt avatar Aug 05 '22 20:08 grimhilt

Thank you for reviewing !

grimhilt avatar Aug 08 '22 18:08 grimhilt

Thank you for reviewing !

nP!

SimonBrandner avatar Aug 09 '22 06:08 SimonBrandner

Apologies this got lost for so long. It looks like https://github.com/element-hq/element-web/issues/20817 has been fixed in the interim. I also just checked and the conclusion is that including your own voice messages in the queue is intentional (I've update the discussion with the context). Since the latter is the only remaining change in this PR, I think, I'm going close this as the current behaviour is what's intended. Let me know if I've missed anything, thanks!

dbkr avatar Jan 12 '24 14:01 dbkr

No problem, thank you for taking care of this !

grimhilt avatar Jan 22 '24 08:01 grimhilt