matrix-react-sdk
matrix-react-sdk copied to clipboard
matrix-org
WIP: Implement `Knocking`
Checklist
- [x] Tests written for new code (and old code if feasible)
- [x] Linter and other CI checks pass
- [x] Sign-off given on the changes (see CONTRIBUTING.md)
Demo for Creating Room:
https://user-images.githubusercontent.com/76884959/180643752-ea90d1e4-8c23-47fb-b3fb-2ce2704a4860.mp4
Demo for Room Settings:
https://user-images.githubusercontent.com/76884959/184091618-28b0603b-526a-4314-af4d-e5e62e460314.mp4
Related PR: vector-im/#22926
This PR currently has none of the required changelog labels.
A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.
Looking great! Just a few nits mainly regarding the desings
@SimonBrandner I've resolved nits and added one more commit, also I;ve updated the video can you please look into it?
@turt2live I've made the recent push and I've also uploaded the video of the updated code which conditionally renders the room settings option according to labs flag, can you verify it? :sweat_smile:
looks to be in the right direction :)
please try to avoid force-pushing (rebasing) after review has already been given - it makes things a bit harder to review. We don't mind merge commits when updating the branch because we'll squash them all down to 1 when we merge the PR.
Agh! sorry for it I just do it in order avoid one extra merge commit everytime I update my branch :sweat_smile: I'll keep it in mind
