matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Improvements of interactions with media in reply messages

Open grimhilt opened this issue 2 years ago • 2 comments

Fixes https://github.com/vector-im/element-web/issues/20150 Improves https://github.com/vector-im/element-web/issues/22911

Improvements of media in reply messages :

  • Voice messages
    • Allows clicking on the play pause button and the seek bar of a voice message without being jumped to the original message
    • Clicking everywhere else will still result in a jump
    • Playing a voice message in a reply will not start a playback queue
  • Images
    • Clicking on the preview of an image inside a reply will open it
    • Clicking everywhere else will still jump you to the original message
  • Media files (including video and audio files)
    • Clicking on the title or button of a file will no longer download it
    • But it will jump you to the origin message

Signed-off-by: [email protected]

Here's what your changelog entry will look like:

✨ Features

Improvements of interactions with media in reply messages (https://github.com/matrix-org/matrix-react-sdk/pull/9069). Fixes https://github.com/vector-im/element-web/issues/20150. Contributed by @grimhilt.


Here's what your changelog entry will look like:

✨ Features

  • Improvements of interactions with media in reply messages (#9069). Fixes vector-im/element-web#20150. Contributed by @grimhilt.

grimhilt avatar Jul 18 '22 01:07 grimhilt

Thank you for reviewing @turt2live I still have one error in the tests but i also have it in the branch develop.

grimhilt avatar Jul 20 '22 00:07 grimhilt

Is there anything i need to do ?

grimhilt avatar Aug 22 '22 20:08 grimhilt

something appears to have gone very wrong with your merge - it's now including commits that are already on develop.

turt2live avatar Jan 04 '23 17:01 turt2live

indeed, i will try to fix this, I think I did a rebase instead of a merge with develop

grimhilt avatar Jan 04 '23 17:01 grimhilt

I'm closing this as it is outdated and it will be easier to start over.

grimhilt avatar Aug 06 '23 16:08 grimhilt