matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Display view source toggle on IRC layout

Open luixxiul opened this issue 2 years ago • 2 comments

Fixes https://github.com/vector-im/element-web/issues/22872

Before After
before after
↑ Against develop branch

Signed-off-by: Suguru Hirahara [email protected]

type: defect

Checklist

  • [x] Tests written for new code (and old code if feasible)
  • [x] Linter and other CI checks pass
  • [x] Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Display view source toggle on IRC layout (#9066). Fixes vector-im/element-web#22872. Contributed by @luixxiul.

luixxiul avatar Jul 17 '22 10:07 luixxiul

@kerryarchibald

Overlaps with read receipt: Screenshot 2022-07-18 at 10 21 54

It should be fixed once https://github.com/matrix-org/matrix-react-sdk/pull/9058 lands.

Clips out of message area, leaving very small clickable area:

This is a separate issue, which not only is applied to IRC layout but also modern/group layout and bubble layout.

It should be addressed with another PR.

In message bubbles, overlaps with reactions: (This one looks pretty bad on develop already, but at least doesn't overlap)

This is also a separate issue. This PR only changes _IRCLayout.pcss.

Except fixing a conflict, I believe there is nothing to change on this PR.

luixxiul avatar Jul 19 '22 10:07 luixxiul

Will rereview after #9058 lands to check the read receipt overlap.

kerryarchibald avatar Jul 20 '22 06:07 kerryarchibald