matrix-react-sdk
matrix-react-sdk copied to clipboard
matrix-org
Add test to check inline start padding of EventTile_line of GenericEventListSummary on IRC layout
This PR is a follow-up to https://github.com/matrix-org/matrix-react-sdk/pull/9063 to add a test for checking the inline start padding (padding-left) of EventTile_line of GenericEventListSummary on IRC layout.
The name width --name-width was set to 70px on this line of #4531, while at the same time the default value was set to 80px on this line of the same PR. The reason is not clear, but since the latter value has been respected, the former should be able to be safely changed to 80px.
Signed-off-by: Suguru Hirahara [email protected]
type: task
Checklist
- [x] Tests written for new code (and old code if feasible)
- [x] Linter and other CI checks pass
- [x] Sign-off given on the changes (see CONTRIBUTING.md)
This change is marked as an internal change (Task), so will not be included in the changelog.
If only CSS properties are asserted without a screenshot this test should be a jest unit-test. You can ask for support on how to do this through the usual channels.
Except Jest doesn't load CSS due to it being loaded by the Element Web layer, thus needing an end-to-end test given how we structure our components.
Hi @luixxiul can you please update your branch and resolve the conflicts?
Hmm :thinking: They are looking both wrong
Were the screenshots taken too early, when the layout is still settling down?
I guess it is due to https://github.com/matrix-org/matrix-react-sdk/pull/9064/files#diff-8aa427661b195fe975f24c7fcc49a73653161921f730b265699f3492821bebd6R173, which is not added by this PR.
That is not what I mean. When looking at the actual app everything is bottom-aligned:
Both screenshots look different.
The test has been already implemented with another PR. The issue related to the --name-width still exists, so I opened a PR for it as the main goal of this PR was to implement the test.