matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Published 20 hours ago • verified publisher icon matrix-org

Remove old Room Directory

Open justjanne opened this issue 3 years ago • 1 comments

Type: Task Fixes: https://github.com/vector-im/element-web/issues/22846

This change is marked as an internal change (Task), so will not be included in the changelog.

justjanne avatar Jul 14 '22 13:07 justjanne

this appears to be a fairly massive change for the app, so would appreciate explicit review from the product and/or design team.

turt2live avatar Aug 24 '22 19:08 turt2live

Are there any visual changes associated with this PR? Any risk of any remaining functionality breaking?

kittykat avatar Oct 17 '22 20:10 kittykat

The UI change would be the loss of the public room directory button (from the home view). It's less of a risk than what it used to be, but also still fairly significant.

turt2live avatar Oct 17 '22 20:10 turt2live

Changing the home screen is a more complicated issue which needs product thinking. Can that button link to this view instead of the old one?

Screenshot from 2022-10-17 22-11-06

kittykat avatar Oct 17 '22 21:10 kittykat

@kittykat that is already what happens, all interactions which went to the dialog being removed are re-routed to Spotlight-in-the-explore-state

image image image image

t3chguy avatar Oct 18 '22 12:10 t3chguy

Superseeded by https://github.com/matrix-org/matrix-react-sdk/pull/9605

germain-gg avatar Nov 22 '22 15:11 germain-gg