matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Remove mx_EventTile:not([data-layout=bubble]) selector

Open luixxiul opened this issue 2 years ago • 0 comments

This PR moves declarations out of mx_EventTile:not([data-layout=bubble]) to remove the selector and to make it easy to create new layouts without a bunch of hacks to override the style rules with increased specificity due to :not() pseudo class, merging the style rules on _EventBubbleTile.scss.

Because the rules inside mx_EventTile:not([data-layout=bubble]) have been applied anywhere except mx_EventTile[data-layout=bubble] even outside of the timelines such as FilePanel, it is not really possible to apply those rules for data-layout=irc / data-layout=group. Therefore this PR applies the declarations globally first, and then cancels what has not been used for bubble layout. This might look redundant, but this should be safer.

The next task would be to clean up rules which have been added against increased specificity due to :not() pseudo class.

type: task

Signed-off-by: Suguru Hirahara [email protected]


This change is marked as an internal change (Task), so will not be included in the changelog.

luixxiul avatar Jul 09 '22 11:07 luixxiul