matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Improve _IRCLayout.scss to remove space between the avatar and info text

Open luixxiul opened this issue 2 years ago • 4 comments

This PR organizes style rules on _IRCLayout.scss to clarify the structure.

Before After

type: task


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Improve _IRCLayout.scss to remove space between the avatar and info text (#8858). Contributed by @luixxiul.

luixxiul avatar Jun 17 '22 09:06 luixxiul

Do you mind if I would ask the reason why converting to draft has to be avoided?

luixxiul avatar Jun 30 '22 02:06 luixxiul

it ends up skewing our PR review latency statistics, and confuses the team trying to review the PR.

Opening a PR as a draft is fine, though once marked "ready for review" the assumption is that it's ready for review - it should not be converted back to draft as we cannot clear the code review request without manual intervention.

turt2live avatar Jun 30 '22 02:06 turt2live

I understood.

Is it not possible for admins to disable converting back something to draft? Otherwise a PR template should mention that at least, IMHO. Not everyone knows how PR review is conducted.

luixxiul avatar Jun 30 '22 02:06 luixxiul

we're working on PR review guidance, and are fixing our contributing guidelines, though both are a bit slow (sorry).

turt2live avatar Jun 30 '22 03:06 turt2live

Closing as stale

luixxiul avatar Feb 20 '23 08:02 luixxiul