matrix-react-sdk
matrix-react-sdk copied to clipboard
Implement a message for user account suspension, as per MSC3823.
Users may have their account temporarily suspended from a homeserver, e.g. due to ToS violations. This prevents them from sending new messages but not from reading messages or redacting their own messages.
This patch displays an error message comparable to "some of your messages have not been sent".
See https://github.com/matrix-org/synapse/pull/12845 for more details.
Here's what your changelog entry will look like:
✨ Features
- Implement a message for user account suspension, as per MSC3823. (#8722). Contributed by @Yoric.
Unfortunately, I have no idea how to write a test for such a feature.
The test failure seems to be a timeout in unrelated code.
For testing: a cypress test would be appreciated. It allows you to run a Synapse and call endpoints, which should be enough to trigger and test suspension.
Matching screenshot:
Also, test added.
@Yoric that screenshot looks rather broken
It is likely even worse with different scaling/font settings.
@Yoric that screenshot looks rather broken
It is likely even worse with different scaling/font settings.
Yes, I believe that this is what what the status bar currently looks like on 1000x660 (the default size for cypress), even without my patch.
Here's a screenshot with a more reasonable 1280x1024:
The cypress test passes locally but fails with the following error message in CI:
Error: Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_00e45d6c-6a29-4cbf-a707-3052823681c4/7b22363b-0b56-4817-8fec-0cd31a12eaad.tar.gz. return code: 2.
I don't have the authorization to relaunch tests.
Here's a screenshot with a more reasonable 1280x1024:
Until you open the right panel, surely?
Here's a screenshot with a more reasonable 1280x1024:
Until you open the right panel, surely?
You are right.
Note that the problem already shows up prior to this patch, though.
I would suggest fixing this for good in a followup issue, as I clearly do not have a fine enough understanding of the CSS of Element Web for this purpose, plus this feels like a bit too much scope extension for this PR.
Note: Latest cypress error seems to be a timeout in unrelated code.
It looks like progress here has halted for now. Thank you for your work on this. The code and the Netlify build will continue to exist, so this can still be used to validate the MSC if needed, but I'm going to close the PR until it's being actively worked on.