matrix-react-sdk
matrix-react-sdk copied to clipboard
matrix-org
Allows search to recognize full room links
Fix: Allows search to recognize full room links
Before: Element search could not recognise full room links
After: Element recognises full links for all types of rooms and channels (not just matrix.to rooms)
The left panel search automatically changes search to a recognizable room name on copy and paste
Fixes https://github.com/vector-im/element-web/issues/21695
Here's what your changelog entry will look like:
✨ Features
- Allows search to recognize full room links (#8275). Contributed by @bolu-tife.
Oh my mistake, I must have reverted the commits when I made a sign off. I'll make a new pull request to address that
Here is the change: https://github.com/matrix-org/matrix-react-sdk/pull/8275/commits/9ba6051fc3fff165323cade51660707b26406aa8
@bolu-tife, could you please put Fixes <issue link> into the PR description, so that it auto-closes the issue when merged?
Codecov Report
Merging #8275 (c26fbf2) into develop (3750b90) will decrease coverage by
0.00%. The diff coverage is0.00%.
@@ Coverage Diff @@
## develop #8275 +/- ##
===========================================
- Coverage 30.02% 30.02% -0.01%
===========================================
Files 879 880 +1
Lines 50168 50172 +4
Branches 12772 12773 +1
===========================================
Hits 15062 15062
- Misses 35106 35110 +4
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/components/structures/RoomDirectory.tsx | 0.79% <0.00%> (ø) |
|
| src/components/views/dialogs/SpotlightDialog.tsx | 5.85% <0.00%> (ø) |
|
| src/utils/SearchInput.ts | 0.00% <0.00%> (ø) |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Does this only apply to matrix.to URLs that use room aliases (https://github.com/vector-im/element-web/issues/21695), or also those based on room IDs (partially https://github.com/vector-im/element-web/issues/22500)?
@bolu-tife thanks for submitting the PR :) is there any chance you might have time to update it based on comments? Looking forward to it getting merged! :+1:
@tonkku107 if you would like to work on this, it appears to have been abandoned by @bolu-tife , so feel free to make your own branch based on this one, and address the comments above, including the need for tests. Thanks!
@tonkku107 (thanks to @t3chguy for pointing out) - some of the commits from @bolu-tife are not signed off, so unless they re-appear and sign them off or add a sign-off to the PR description, you would need to start again from scratch instead of building on this work :-(
I apologies for the delay. Would you like to work on them? @tonkku107 I can sign them off or pick them up now as i am fully available. Thank you for your time @andybalaam
Hello @bolu-tife. Firstly I'm sorry for the delay on this. I'm trying to get this moving now. As a first step please could you merge the latest develop into your branch and we'll go from there.
Thank you. I've merged the develop branch into this feature branch. @alunturner
I just noticed another ts error. I would work on it.
I have worked in it.
@bolu-tife, be sure to hit the little wheel next to the reviewer's name, to re-request their review!
@bolu-tife, be sure to hit the little wheel next to the reviewer's name, to re-request their review!
okay, thank you! @SimonBrandner
@bolu-tife, be sure to hit the little wheel next to the reviewer's name, to re-request their review!
okay, thank you! @SimonBrandner
No problem!