matrix-react-sdk
matrix-react-sdk copied to clipboard
matrix-org
Adding Show default amount of rooms button
This should help with https://github.com/vector-im/element-web/issues/16665
Signed-off-by: Chagai Friedlander [email protected]
Preview: https://619bbbec5be11726eb1f7655--matrix-react-sdk.netlify.app ⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.
Here's what your changelog entry will look like:
✨ Features
- Adding Show default amount of rooms button (#6519). Contributed by @chagai95.
@chagai95 Hi Chagai. I appreciate you taking the time to document that interaction issue and then come up with a proposal, but I'm afraid this is not the best way to solve it.
First, the CTA button makes the whole popover look like a form, for which the "Show default amount of room" would be the submit button.
There's also a clear disconnect between where you interact with the "Show more" action and where you can override its effect. It's hard to discover that connection/relationship. Then, it's also going to be confusing for people seeing such a prominent action by default, for no special reason.
A floating/sticky "Collapse List" action fixed to the bottom of the scrollable area of the room list could solve it in a more intuitive way, but this does require more product/design thinking and exploration to come up with an elegant solution that works intuitively for everyone.
@chagai95 Hi Chagai. I appreciate you taking the time to document that interaction issue and then come up with a proposal, but I'm afraid this is not the best way to solve it.
Thanks for answering. Is it ok as a workaround in the labs section?
First, the CTA button makes the whole popover look like a form, for which the "Show default amount of room" would be the submit button.
If I made it white, will that be better?
There's also a clear disconnect between where you interact with the "Show more" action and where you can override its effect. It's hard to discover that connection/relationship. Then, it's also going to be confusing for people seeing such a prominent action by default, for no special reason.
I understand you're afraid of confusing people but I cannot find the show less button the way it is done now so the proposal is not meant to be perfect, just a little bit better than what it is now, do you think it's worse than how it is now? I understand it'll confuse people but as a lab feature with an extensive explanation that should be ok then?
A floating/sticky "Collapse List" action fixed to the bottom of the scrollable area of the room list could solve it in a more intuitive way, but this does require more product/design thinking and exploration to come up with an elegant solution that works intuitively for everyone.
I'm sorry but I'm not following you... Could you elaborate or maybe give an example? A college at work came up with an idea today, why not add another small section similar to the spaces section and have filtering between sections there rather than having to scroll up and down to find the sections... An example for this is Microsoft Teams, if you'd like I can make a screen recording showing this 😉
Is it ok as a workaround in the labs section?
Labs is intended for work-in-progress things, rather than workarounds.
Is it ok as a workaround in the labs section?
Labs is intended for work-in-progress things, rather than workarounds.
(or dev tools - hidden events)
(or dev tools - hidden events)
Honestly, that shouldn't be a labs flag, should be a toggle in /devtools
Is it ok as a workaround in the labs section?
Labs is intended for work-in-progress things, rather than workarounds.
Ok, so I guess I'm back to asking if it's better to have people confused by this than to have them scroll around forever... Maybe I'll make a video showing how you end up scrolling around... 🙈 I'm open to any other suggestions, I was bothered enough by this to actually create a PR and I'm sure a lot of people are as well...
Sorry for the volume, I'll try making a new video but maybe you can hear something...
https://chagai.website/scrolling-around-to-find-show-less.mp4
It looks like there's a misalignment between you and the design team at the moment
The best forum to realign and move this forward would be to discuss this over #matrix-design:matrix.org and then make the code adjustment as I can see a difference in approach here
It looks like there's a misalignment between you and the design team at the moment
The best forum to realign and move this forward would be to discuss this over #matrix-design:matrix.org and then make the code adjustment as I can see a difference in approach here
https://matrix.to/#/#element-design:matrix.org seems more appropriate
Hey @chagai95 thanks for the PR!
Counter intuitive to the comments above it'd be better to keep the discussion to this PR— we can explore some options and discuss asynchronously, and then discuss sync either in that room or by 1:1 in DM at a point which would be more productive.
We have context in this PR, @janogarcia (designer) from the core team is already context switched into the problem space, but we can't guarantee his availability to discuss this at the time you're posting (he deserves a weekend :).
Would it make sense to merge the conflicts? I think this problem is not going to be solved soon in a better way, so why not do this? Is the design the issue?
Would it make sense to merge the conflicts? I think this problem is not going to be solved soon in a better way, so why not do this? Is the design the issue?
Yes, it is a design issue - you'd need design to approve this change
Ok thx so I won't merge yet, could i get someone's attention on this to decide what design would be ok? If I would add a config for this would it mean i could skip the design team approval?
Ok thx so I won't merge yet, could i get someone's attention on this to decide what design would be ok? If I would add a config for this would it mean i could skip the design team approval?
The only way to skip design might be a labs option
Adding more labs flags increases tech debt, we are unlikely to allow that for this.
Has the exact same amount of tech debt, supporting a feature which won't be properly tested and will need maintenance from the core team. This will need approval from product/design
A floating/sticky "Collapse List" action fixed to the bottom of the scrollable area of the room list could solve it in a more intuitive way, but this does require more product/design thinking and exploration to come up with an elegant solution that works intuitively for everyone.
@chagai95
So, I've put together some mockups to illustrate what I had in mind when I posted that comment above. I still don't think moving the collapse behavior to the popover menu is the most intuitive thing.
Basically, a floating action for collapsing room/people lists that is revealed when those are fully uncollapsed.
I need to discuss this direction further with the design team (planning it for this Thursday) and make sure it works in dark and narrow viewport modes.
What do you mean with a detailed spec? I can definitely try to do something, but I don't want to commit to anything...
@chagai95 Makes sense. It would be about describing how the "Show less" floating action should behave. That is, details such as when and how it's revealed and hidden.
@chagai95 I am going to close this PR. Reading the comments the current approach does not align with what design/product wants to have. Nevertheless thank you for your work on this :+1:
Any further discussion should happen in https://github.com/vector-im/element-web/issues/16665
Ah such a pity, it's still an every day struggle for me....
The room list is currently being redesigned. Hopefully the new version will solve your problem. However, nothing is ready yet.