matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

improve auto fill password/passphrase

Open chagai95 opened this issue 3 years ago • 4 comments

Add a hidden username input field that has a field to differentiate between password and passphrase autofill

as explained in this issue https://github.com/vector-im/element-web/issues/16484

Signed-off-by: Chagai Friedlander [email protected]


Here's what your changelog entry will look like:

✨ Features

  • improve auto fill password/passphrase (#6289). Contributed by @chagai95.

chagai95 avatar Jun 29 '21 21:06 chagai95

@t3chguy is this better?

chagai95 avatar Jun 30 '21 19:06 chagai95

the conflicting credentials bit is concerning :(

Why is it concerning? if anyone can pick it up from here that'll also be great, it seems to work for us like this and it makes logging in much easier so I thought it'll be nice for you too, if the code isn't good I understand, hopefully someone else is interested in fixing this, otherwise I'll try myself sometime...

chagai95 avatar Oct 20 '21 05:10 chagai95

The code looks fine, but as mentioned in the review thread it can cause some conflicts with some credentials. I'd be very curious to see if the section-passphrase stuff works - if it does, we should use that, but otherwise this change as-is is probably fine too.

turt2live avatar Oct 20 '21 06:10 turt2live

I'll try giving it a look soon but would also appreciate if this PR is already merged as is, it's already extremely helpful for me on our fork and I'm sure many will profit from this is as even though it'll much better if it does not conflict.

chagai95 avatar Oct 20 '21 07:10 chagai95

No activity recently, and probably superseded by OIDC work.

andybalaam avatar May 25 '23 14:05 andybalaam

Please re-open if you want to work on it, and thank you.

andybalaam avatar May 25 '23 14:05 andybalaam