matrix-react-sdk
matrix-react-sdk copied to clipboard
matrix-org
Share a URL to chat
Raised in https://gitlab.com/minds/front/-/issues/4666
This adds a new InviteDialog kind, which is opened on https://app.element.io/#/share?url=something.com, and that allows the user to send a url to a chat or chats.
Here's what your changelog entry will look like:
✨ Features
- Share a URL to chat (#6273). Contributed by @manishoo.
@manishoo, thanks for working on this! Could you please fix the eslint issues and re-run the i18n script (yarn i18n), that will regenerate the translation file?
The modal would certainly need to show what you're about to send, maybe instead of using the InviteDialog as a base, look at the ForwardDialog
The modal would certainly need to show what you're about to send, maybe instead of using the InviteDialog as a base, look at the ForwardDialog
Yes I agree. I initially built it based on how the same feature is implemented on Telegram (which does not show the content of the message). However it's understandable that showing the content before the message is sent is a more robust implementation.
p.s. I was not aware of the ForwardDialog, thank you for mentioning it. I'll revise the code asap
@t3chguy hey Michael is there anything I should do to get this merged?
This is waiting for a product review, which often takes a while because the product team is quite busy, sorry
@manishoo thanks for contributing this and apologies it's been stuck in review backlog for so long. Just a quick note to let you know this is on my list to take a closer look at - we're definitely interested in merging the contribution, I just need to validate how it might interact with some other work we're planning now on sharing functionality for the near future.
Will revert when I have more!
This strikes me as a useful feature with limited impact on the UI. So I'm proposing we move ahead and land this.
@manishoo are you available to resolve the conflicts?
Marking as draft since this is not in a state to merge. Contributions welcome!
I'm closing this since it's not actually been actioned in a long while. We'd still very much appreciate contributions here. So happy to reopen this again or receive a new PR.