matrix-react-sdk
matrix-react-sdk copied to clipboard
matrix-org
Improvements to alt aliases
Attempt 2 at https://github.com/matrix-org/matrix-react-sdk/pull/4574
Step towards fixing https://github.com/vector-im/element-web/issues/13077
TR: Video
https://user-images.githubusercontent.com/5855073/122130924-ff628a00-cdfd-11eb-9100-c308f4067156.mov
Here's what your changelog entry will look like:
🐛 Bug Fixes
- Improvements to alt aliases (#6180). Contributed by @aaronraimist.
When I get back to the computer I’ll take some but it looks exactly like the original PR. It’s best experienced by using the Netlify preview or building it yourself.
https://user-images.githubusercontent.com/5855073/122130924-ff628a00-cdfd-11eb-9100-c308f4067156.mov
If it comes down to it, what is your interest in maintaining this and potentially pushing it forward with design support? Including potentially (re)writing a bunch of the state machine stuff.
I am not super interested in rewriting it. I was mostly reintroducing this PR because it already passed a code review and was just missing a design review. If it needs to be rewritten then it'll probably have to wait for someone else to pick it up.
@aaronraimist I think this got replaced with https://github.com/matrix-org/matrix-react-sdk/pull/7107 ? Are there remaining bits of this or the linked issue which might still need doing?
@turt2live #7107 is an improvement but in my opinion it doesn't replace this PR. #7107 checks that the address about to be published looked like an alias but this PR actually checks if the alias points at the room and provides a helpful error if not.
Currently if you enter a valid looking alias but it doesn't point at the room, you get this error which doesn't explain much.
I'm not sure if @Palid wants to leave this open and build on top of it or close it and rewrite it in a different way.