matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Increase space panel collapse clickable area

Open jaiwanth-v opened this issue 4 years ago • 2 comments

Fixes vector-im/element-web#17379

image image

I haven't increased this in the Space Room Directory as it looks a bit weird to me on hover. image I'll change it if reviewers think otherwise.


Here's what your changelog entry will look like:

✨ Features

  • Increase space panel collapse clickable area (#6084). Fixes vector-im/element-web#17379. Contributed by @jaiwanth-v.

jaiwanth-v avatar May 24 '21 07:05 jaiwanth-v

@jaiwanth-v thanks for the contribution! Does this impact the layout visually or just increase the click/target area?

nadonomy avatar Jun 17 '21 10:06 nadonomy

It just increases the click area. No visual impact.

jaiwanth-v avatar Jun 17 '21 11:06 jaiwanth-v

I think we should merge this as-is and leave the comments originally raised by @niquewoodhouse on the back-burner.

This does solve a real issue, and no one else is looking at fixing that... The real long term fix would be to address https://github.com/vector-im/element-web/issues/24848

@jaiwanth-v can you resolve the conflicts and this will be good to go

germain-gg avatar Mar 16 '23 16:03 germain-gg