matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Failed reactions Design

Open DantrazTrev opened this issue 4 years ago • 1 comments

Possibly Fixes vector-im/element-web/issues/17034 (Needs a bit design)

Added the EventStatus.NOT_SENT the one used in Resend Reactions to determine the reactions to resend to the ReactionRowsButton for the logic of Failed to sent responses

    const failed =Boolean(mxEvent.staus === EventStatus.NOT_SENT)

Added mx_ReactionsRowButton_failed class to render a failed event . Although it needs a bit more design (The image shows a failed to send reaction)

image

Signed-off-by : Ayush Pratap Singh [email protected]


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Failed reactions Design (#5954). Contributed by @DantrazTrev.

DantrazTrev avatar May 03 '21 12:05 DantrazTrev

It's great to see that we will be able to determine which reactions have stalled

Let's probably wait for the design review, but I'd suggest to add extra information (maybe on hover?) as to why this reaction has turned red, and make it clear to a user how they can resend the reaction

That would help a lot, As an alternative, I'm thinking of something like a red exclamation icon at the end of the failed reaction?

DantrazTrev avatar Jun 01 '21 21:06 DantrazTrev

Hi, thank you for your work on this. We want the design team to take a look at it, and since the linked issue has the right tag on it, it will eventually get to the front of the queue.

Meanwhile, the actual code here is quite short and has bit-rotted, so I am going to close this PR, and hope that someone can create a new one (possibly based on this one) when design get back to us.

Thanks again, and I really hope we will get this feature soon(ish).

andybalaam avatar Nov 10 '22 16:11 andybalaam