matrix-react-sdk
matrix-react-sdk copied to clipboard
matrix-org
Enable user to zoom beyond image size
Fixes vector-im/element-web/issues/17114
Also added some cleanup functions to the image view.
Signed-off-by: Jaiwanth [email protected]
Here's what your changelog entry will look like:
✨ Features
- Enable user to zoom beyond image size (#5949). Contributed by @jaiwanth-v.
Currently, I think it would make most sense if clicking the zoomed out image zoomed you in to 100% but you would be allowed to zoom in further using the buttons or the scroll wheel. That way most of the old behavior is preserved. That being said, this is just my opinion
Currently, I think it would make most sense if clicking the zoomed out image zoomed you in to 100% but you would be allowed to zoom in further using the buttons or the scroll wheel. That way most of the old behavior is preserved.
That sounds reasonable to me, but I also have no idea what Design thinks of this change, so they may have an entirely different idea in mind.
I thought this change was no longer required due to some other PR. Am I wrong?
I thought this change was no longer required due to some other PR. Am I wrong?
From my testing it doesn't seem I can zoom to more than 100% - I don't think there was a PR for this already?
I'm happy to review on behalf of design, if there's a deployment. @jaiwanth-v would you mind merging so I can review please?
Sure. I'll do it soon.
On Mon, Aug 8, 2022, 5:07 PM Nique Woodhouse @.***> wrote:
I'm happy to review on behalf of design, if there's a deployment. @jaiwanth-v https://github.com/jaiwanth-v would you mind merging so I can review please?
— Reply to this email directly, view it on GitHub https://github.com/matrix-org/matrix-react-sdk/pull/5949#issuecomment-1208013167, or unsubscribe https://github.com/notifications/unsubscribe-auth/APU6SOM7AHEI7QDW2Z3M773VYDWOHANCNFSM433JR7AA . You are receiving this because you were mentioned.Message ID: @.***>
@niquewoodhouse Travis just pressed the button, so there should be a testable build within 30 minutes or so. Please ping me if it doesn't appear and we can try to fix it.
