matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Show strikethrough and bold text in room list message previews

Open tanayvk opened this issue 3 years ago • 6 comments

Fixes vector-im/element-web #16330

Changes made:

  • Render HTML content in message previews (using dangerouslySetInnerHTML)
  • Sanitize message preview html to retain only strikethroughs and bold formatting (<del> and <strong> tags)

Edit: Signed-off-by: Tanay Karnik [email protected]


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Show strikethrough and bold text in room list message previews (#5813). Contributed by @tanayvk.

tanayvk avatar Mar 27 '21 09:03 tanayvk

@tanayvk, thanks for working on this! Could you please include a sign-off as described here?

SimonBrandner avatar Mar 27 '21 09:03 SimonBrandner

Sure. I thought I did sign-off, but let me recheck.

tanayvk avatar Mar 27 '21 09:03 tanayvk

Okay for some reason git rebase --signoff origin/develop doesn't seem to add the signoff to the commit messages automatically. Anyway, I have added the sign-off in the PR comment message, that's okay right?

tanayvk avatar Mar 27 '21 09:03 tanayvk

@tanayvk, yeah, that's alright

SimonBrandner avatar Mar 27 '21 09:03 SimonBrandner

Okay done. Message previews now render: italics, underlined, bold, code and strikethroughs.

tanayvk avatar Mar 27 '21 11:03 tanayvk

hey @tanayvk are you able to take a look at updating this?

turt2live avatar Jan 20 '22 23:01 turt2live

This PR hasn't seen any attention for about 6 months, so we should probably close it unless someone is willing to take it on and address the remaining comments.

I'll give it a week and then close if I don't see a response.

andybalaam avatar Sep 15 '22 09:09 andybalaam

Feel free to re-open if you want to get this code rebased and working with the latest!

andybalaam avatar Sep 22 '22 08:09 andybalaam