matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Published 20 hours ago • verified publisher icon matrix-org

Add tray icon blink support

Open rkfg opened this issue 4 years ago • 2 comments

See https://github.com/vector-im/element-desktop/pull/136 for details

Signed-off-by: Sergey Shpikin [email protected]

Part of https://github.com/vector-im/element-web/issues/15017 Related to https://github.com/vector-im/element-desktop/pull/136 Related to https://github.com/vector-im/element-web/pull/15015

Here's what your changelog entry will look like:

✨ Features

  • Add tray icon blink support (#5135). Contributed by @rkfg.

rkfg avatar Aug 21 '20 09:08 rkfg

https://github.com/matrix-org/matrix-js-sdk/blob/master/CONTRIBUTING.rst#sign-off

t3chguy avatar Aug 21 '20 09:08 t3chguy

Hi, thank you for working on this! We found it on our regular review of PRs that we have sadly neglected, sorry :-(

This is going to need review from Product, so we've marked the related issue as X-Needs-Product, which means it goes into a queue and they will get to it eventually.

Since this PR may need changes when the Product work has been done, and it needs conflict resolution, I'm marking it as a Draft for now, so it doesn't come up again in our neglected PRs review.

andybalaam avatar May 19 '22 15:05 andybalaam

Hi there, apologies that it's taken so long for us to get back to your PR here.

From a product and design perspective, blinking icons is not something we want to introduce to our product at this time. It's extremely distracting and not very accessible. While I appreciate that you've already thought of that and added a new setting for users -- we already have too many settings and will need to address that.

Thank you so much for contributing, sorry that it's not something we're ready for at this time.

daniellekirkwood avatar Apr 18 '23 16:04 daniellekirkwood