matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard
verified publisher icon matrix-org

Let Element Call widget receive m.room.create

Open AndrewFerr opened this issue 1 year ago • 1 comments

This allows the widget to check the room version without prompting the user to grant that capability, so the widget can know about version-specific auth rules (namely MSC3779).

Signed-off-by: Andrew Ferrazzutti [email protected]

Checklist

  • [ ] Tests written for new code (and old code if feasible).
  • [ ] New or updated public/exported symbols have accurate TSDoc documentation.
  • [x] Linter and other CI checks pass.
  • [x] Sign-off given on the changes (see CONTRIBUTING.md).

AndrewFerr avatar Jun 27 '24 19:06 AndrewFerr

Related change: https://github.com/element-hq/element-call/pull/2457 This lets Element Call widgets actually request this capability.

AndrewFerr avatar Jun 27 '24 19:06 AndrewFerr

The change itself looks fine but I'm not sure I understand why the other changes to the test?

dbkr avatar Jul 16 '24 11:07 dbkr

why the other changes to the test?

The "fail fast" changes are just to make the test's failure condition be an expect failure instead of a timeout (due to waiting for a "grant permission" modal dialog to be interacted with).

With that said, it's not strictly related to this PR, so I'll split it out of here.

AndrewFerr avatar Jul 16 '24 12:07 AndrewFerr

Okay, thanks - that seems fine then!

dbkr avatar Jul 16 '24 13:07 dbkr