Redesign room search interface

[t3chguy]

For https://github.com/element-hq/element-web/issues/25883 ~Requires https://github.com/element-hq/compound-web/pull/196~ Requires https://github.com/matrix-org/matrix-react-sdk/pull/12698

[americanrefugee]

A few comments:

• When clicking "Cancel", the search field should be cleared as well
• When the banner is condensed, the button "Search all rooms" should remain on one line, and the text on the left ("XX results for..." and "Open the desktop app...") should be truncated with "..." on one line (in other words, no text wrapping). Example here.
• The Clear ("x") button in the active search field should be bigger, have no background, and have a rollover state as shown in Compound

[t3chguy]

The Clear ("x") button in the active search field should be bigger, have no background, and have a rollover state as shown in Compound

@americanrefugee looks like Compound is using the browser-native x clear button there rather than styling its own. See https://compound.element.io/?path=/docs/compound-web_search--docs

[americanrefugee]

Design LGTM!

However, clicking "Open the desktop app" goes to the download page on element.io... I expected it to actually open the desktop app. Is that intentional?

[t3chguy]

However, clicking "Open the desktop app" goes to the download page on element.io... I expected it to actually open the desktop app. Is that intentional?

Yes, there's no way to detect if you have the app installed. The old text was to Use the desktop app, which may mean acquiring it first, this is the text I shared with you in the room but then the Figma said open. Most users would not be using Element Web if they already had Element Desktop installed.

Have updated the copy to Get the Desktop app...

[americanrefugee]

However, clicking "Open the desktop app" goes to the download page on element.io... I expected it to actually open the desktop app. Is that intentional?

Yes, there's no way to detect if you have the app installed. The old text was to Use the desktop app, which may mean acquiring it first, this is the text I shared with you in the room but then the Figma said open. Most users would not be using Element Web if they already had Element Desktop installed.

Have updated the copy to Get the Desktop app...

I see. If possible, can we change "Open..." back to "Use..."? Not a blocker if you can't make this change, but I at least wanted to agree with you :)

[t3chguy]

Yes we can make the copy whatever we like.