matrix-react-sdk icon indicating copy to clipboard operation
matrix-react-sdk copied to clipboard

Add pressable eye in password input to display wrong password

Open aulamber opened this issue 2 years ago • 3 comments

Addressed issue: Users can make a typing mistake when entering their password. An error message is then displayed, but the user cannot know where they made a mistake in entering their password since it is hidden.

Proposed solution: Inside the input (in the right side of it), add an eye icon and when the user presses on it, show the previously hidden password (attention: when the user presses, not click, so that when the user stops touching the eye icon, the password is hidden once again).

Example:

  • Current behavior Capture d’écran 2023-05-09 à 14 43 48

  • Proposed solution

  1. without pressing the eye: Capture d’écran 2023-05-09 à 14 44 07

  2. while pressing the eye Capture d’écran 2023-05-09 à 14 44 18


This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

aulamber avatar May 09 '23 12:05 aulamber

How does this look on browsers/environments which already have this feature natively?

image

Edit:

Not great image

t3chguy avatar May 09 '23 17:05 t3chguy

How does this look on browsers/environments which already have this feature natively?

image Edit:

Not great image

Can you tell us where you reproduce this double eye, on which browser(s) and environment(s)? For the microsoft eye (the one in your screenshot it seems), we could hide their eye, with this code:

input::-ms-reveal {
  display:none;
}

aulamber avatar May 30 '23 06:05 aulamber

Can you tell us where you reproduce this double eye, on which browser(s) and environment(s)?

The above was Edge on Windows 11

cc @gsouquet as you mentioned Compound input fields will have a password reveal

t3chguy avatar May 30 '23 08:05 t3chguy